Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use expr.parse to fix issue with bracket expression with :to #505

Merged
merged 2 commits into from
Nov 19, 2018
Merged

Use expr.parse to fix issue with bracket expression with :to #505

merged 2 commits into from
Nov 19, 2018

Conversation

Mattchewone
Copy link
Contributor

This fixes #496 allowing bracket notation with :to

@Mattchewone Mattchewone self-assigned this Nov 16, 2018
phillipskevin
phillipskevin requested changes Nov 19, 2018
View reviewed changes
Copy link
Contributor

@phillipskevin phillipskevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing, but otherwise looks good.

test/colon/element-test.js Outdated Show resolved Hide resolved
@phillipskevin phillipskevin merged commit cd1ce5f into master Nov 19, 2018
@phillipskevin phillipskevin deleted the 496-bracket-expr-with-to branch November 19, 2018 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillipskevin phillipskevin phillipskevin approved these changes

Assignees

@Mattchewone Mattchewone

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot use a Bracket Expression with :to bindings
2 participants
@Mattchewone @phillipskevin