Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup markdown sample code #465

Merged
merged 4 commits into from
Feb 15, 2018
Merged

Cleanup markdown sample code #465

merged 4 commits into from
Feb 15, 2018

Conversation

christopherjbaker
Copy link
Contributor

This pull request was created with Landscaper.
The following code mods were used to create this PR:

  1. https://gist.github.com/christopherjbaker/49b7e985b37032902d68a17dd2daa070

Please review this PR carefully as Landscaper does not guarantee any code mod's quality.

Copy link
Contributor

@phillipskevin phillipskevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The consts, lets, and imports look good.

As mentioned here, I have the same concerns as @chasenlehara about tabs -> spaces.

@christopherjbaker christopherjbaker changed the base branch from md-code-fixes to master February 13, 2018 23:59
@christopherjbaker christopherjbaker changed the title Use const/let in sample code Cleanup markdown sample code Feb 13, 2018
@christopherjbaker christopherjbaker merged commit 506aa30 into master Feb 15, 2018
@christopherjbaker christopherjbaker deleted the landscaper/3846-es6 branch February 15, 2018 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants