Use default noop function for unregistered tags. #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a tag handler is requested but the tag does not exist, an anonymous noop function is returned. It should instead return the new default noop function. This is needed for consuming packages to check if the requested tag does not exist. - Updated main to export a default noop - Updated main to return default noop when requested tag does not exist - Updated tests to check use cases
bmomberger-bitovi
approved these changes
Sep 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a tag handler is requested but the tag does not exist, an anonymous noop function is returned. It should instead return the new default noop function. This is needed for consuming packages to check if the requested tag does not exist.
Needed for this issue: canjs/can-view-import#2