#1872: map attribute 'for' to 'htmlFor' property

canjs · Sep 15, 2015 · 5a3480e · 5a3480e
1 parent 1721ea2
commit 5a3480e
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 0 deletions.
diff --git a/util/attr/attr.js b/util/attr/attr.js
@@ -42,6 +42,7 @@ steal("can/util/can.js", function (can) {
 				"value": "value",
 				"innertext": "innerText",
 				"textcontent": "textContent",
+				"for": "htmlFor",
 				"checked": true,
 				"disabled": true,
 				"readonly": true,

diff --git a/util/attr/attr_test.js b/util/attr/attr_test.js
@@ -84,6 +84,27 @@ steal('can/util', 'can/view/mustache', 'can/util/attr', 'steal-qunit', function
 		can.remove(can.$("#qunit-fixture>*"));
 	});
 
+	test("Map special attributes", function () {
+
+		var div = document.createElement("div");
+
+		document.getElementById("qunit-fixture").appendChild(div);
+
+		can.attr.set(div, "class", "my-class");
+		equal(div.className, "my-class", "Map class to className");
+
+		can.attr.set(div, "for", "my-for");
+		equal(div.htmlFor, "my-for", "Map for to htmlFor");
+
+		can.attr.set(div, "innertext", "my-inner-text");
+		equal(div.innerText, "my-inner-text", "Map innertext to innerText");
+
+		can.attr.set(div, "textcontent", "my-content");
+		equal(div.textContent, "my-content", "Map textcontent to textContent");
+
+		can.remove(can.$("#qunit-fixture>*"));
+	});
+
 	if (window.jQuery || window.Zepto) {
 
 		test("zepto or jQuery - bind and unbind", function () {

diff --git a/util/attr/test.html b/util/attr/test.html
@@ -0,0 +1,10 @@
+<!doctype html>
+<html>
+<head> </head>
+<body>
+<div id="qunit"></div>
+<div id="qunit-fixture"></div>
+<script src="../../node_modules/steal/steal.js"
+		data-main="util/attr/attr_test"></script>
+</body>
+</html>