Fixes firefox

canjs · Nov 12, 2015 · b9fead5 · b9fead5
1 parent d898369
commit b9fead5
Show file tree

Hide file tree

Showing 17 changed files with 133 additions and 121 deletions.
diff --git a/package.json b/package.json
@@ -247,4 +247,4 @@
 		"./util/vdom/build_fragment/build_fragment": "./dist/cjs/util/vdom/build_fragment/build_fragment",
 		"./view/import/import": "./dist/cjs/view/import/import"
 	}
-}
+}
diff --git a/test/dev/dojo.html b/test/dev/dojo.html
@@ -39,6 +39,7 @@ <h2 id="qunit-userAgent"></h2>
         QUnit.config.autostart = false;
     </script>
 
+    <script type="text/javascript" src="node_modules/can-simple-dom/node_modules/micro-location/lib/micro-location.js"></script>
     <script type="text/javascript" src="node_modules/can-simple-dom/dist/global/can-simple-dom.js"></script>
     <script type="text/javascript" src="util/dojo/dojo-1.8.1.js"></script>
     <script type="text/javascript" src="dist/can.dojo.dev.js"></script>

diff --git a/test/dev/jquery-2.html b/test/dev/jquery-2.html
@@ -39,6 +39,7 @@ <h2 id="qunit-userAgent"></h2>
         QUnit.config.autostart = false;
     </script>
 
+    <script type="text/javascript" src="node_modules/can-simple-dom/node_modules/micro-location/lib/micro-location.js"></script>
     <script type="text/javascript" src="node_modules/can-simple-dom/dist/global/can-simple-dom.js"></script>
     <script type="text/javascript" src="bower_components/jquery/dist/jquery.js"></script>
     <script type="text/javascript" src="dist/can.jquery.dev.js"></script>

diff --git a/test/dev/jquery.html b/test/dev/jquery.html
@@ -39,6 +39,7 @@ <h2 id="qunit-userAgent"></h2>
         QUnit.config.autostart = false;
     </script>
 
+    <script type="text/javascript" src="node_modules/can-simple-dom/node_modules/micro-location/lib/micro-location.js"></script>
     <script type="text/javascript" src="node_modules/can-simple-dom/dist/global/can-simple-dom.js"></script>
     <script type="text/javascript" src="node_modules/jquery/dist/jquery.js"></script>
     <script type="text/javascript" src="dist/can.jquery.dev.js"></script>

diff --git a/test/dev/mootools.html b/test/dev/mootools.html
@@ -39,6 +39,7 @@ <h2 id="qunit-userAgent"></h2>
         QUnit.config.autostart = false;
     </script>
 
+    <script type="text/javascript" src="node_modules/can-simple-dom/node_modules/micro-location/lib/micro-location.js"></script>
     <script type="text/javascript" src="node_modules/can-simple-dom/dist/global/can-simple-dom.js"></script>
     <script type="text/javascript" src="bower_components/mootools/dist/mootools-core.js"></script>
     <script type="text/javascript" src="dist/can.mootools.dev.js"></script>

diff --git a/test/dev/yui.html b/test/dev/yui.html
@@ -39,6 +39,7 @@ <h2 id="qunit-userAgent"></h2>
         QUnit.config.autostart = false;
     </script>
 
+    <script type="text/javascript" src="node_modules/can-simple-dom/node_modules/micro-location/lib/micro-location.js"></script>
     <script type="text/javascript" src="node_modules/can-simple-dom/dist/global/can-simple-dom.js"></script>
     <script type="text/javascript" src="util/yui/yui-3.7.3.js"></script>
     <script type="text/javascript" src="dist/can.yui.dev.js"></script>

diff --git a/test/dev/zepto.html b/test/dev/zepto.html
@@ -39,6 +39,7 @@ <h2 id="qunit-userAgent"></h2>
         QUnit.config.autostart = false;
     </script>
 
+    <script type="text/javascript" src="node_modules/can-simple-dom/node_modules/micro-location/lib/micro-location.js"></script>
     <script type="text/javascript" src="node_modules/can-simple-dom/dist/global/can-simple-dom.js"></script>
     <script type="text/javascript" src="bower_components/zepto/zepto.js"></script>
     <script type="text/javascript" src="dist/can.zepto.dev.js"></script>

diff --git a/test/dist/dojo.html b/test/dist/dojo.html
@@ -41,6 +41,7 @@ <h2 id="qunit-userAgent"></h2>
         module = undefined;
     </script>
 
+    <script type="text/javascript" src="node_modules/can-simple-dom/node_modules/micro-location/lib/micro-location.js"></script>
     <script type="text/javascript" src="node_modules/can-simple-dom/dist/global/can-simple-dom.js"></script>
     <script type="text/javascript">
         module = MODULE_ALIAS;

diff --git a/test/dist/jquery-2.html b/test/dist/jquery-2.html
@@ -41,6 +41,7 @@ <h2 id="qunit-userAgent"></h2>
         module = undefined;
     </script>
 
+    <script type="text/javascript" src="node_modules/can-simple-dom/node_modules/micro-location/lib/micro-location.js"></script>
     <script type="text/javascript" src="node_modules/can-simple-dom/dist/global/can-simple-dom.js"></script>
     <script type="text/javascript">
         module = MODULE_ALIAS;

diff --git a/test/dist/jquery.html b/test/dist/jquery.html
@@ -41,6 +41,7 @@ <h2 id="qunit-userAgent"></h2>
         module = undefined;
     </script>
 
+    <script type="text/javascript" src="node_modules/can-simple-dom/node_modules/micro-location/lib/micro-location.js"></script>
     <script type="text/javascript" src="node_modules/can-simple-dom/dist/global/can-simple-dom.js"></script>
     <script type="text/javascript">
         module = MODULE_ALIAS;

diff --git a/test/dist/mootools.html b/test/dist/mootools.html
@@ -41,6 +41,7 @@ <h2 id="qunit-userAgent"></h2>
         module = undefined;
     </script>
 
+    <script type="text/javascript" src="node_modules/can-simple-dom/node_modules/micro-location/lib/micro-location.js"></script>
     <script type="text/javascript" src="node_modules/can-simple-dom/dist/global/can-simple-dom.js"></script>
     <script type="text/javascript">
         module = MODULE_ALIAS;

diff --git a/test/dist/yui.html b/test/dist/yui.html
@@ -41,6 +41,7 @@ <h2 id="qunit-userAgent"></h2>
         module = undefined;
     </script>
 
+    <script type="text/javascript" src="node_modules/can-simple-dom/node_modules/micro-location/lib/micro-location.js"></script>
     <script type="text/javascript" src="node_modules/can-simple-dom/dist/global/can-simple-dom.js"></script>
     <script type="text/javascript">
         module = MODULE_ALIAS;

diff --git a/test/dist/zepto.html b/test/dist/zepto.html
@@ -41,6 +41,7 @@ <h2 id="qunit-userAgent"></h2>
         module = undefined;
     </script>
 
+    <script type="text/javascript" src="node_modules/can-simple-dom/node_modules/micro-location/lib/micro-location.js"></script>
     <script type="text/javascript" src="node_modules/can-simple-dom/dist/global/can-simple-dom.js"></script>
     <script type="text/javascript">
         module = MODULE_ALIAS;

diff --git a/test/jquery-2.html b/test/jquery-2.html
@@ -58,7 +58,6 @@
                 "can/view/autorender/autorender_test.js",
                 "can/util/vdom/build_fragment/build_fragment_test.js",
                 "can/view/import/import_test.js",
-                "can/util/jquery/jquery_test.js",
                 function() {
                     can.dev.logLevel = 3;
                 });
@@ -67,4 +66,4 @@
     <div id="qunit-fixture"></div>
 </body>
 
-</html>
+</html>
diff --git a/test/jquery.html b/test/jquery.html
@@ -56,7 +56,6 @@
                 "can/view/autorender/autorender_test.js",
                 "can/util/vdom/build_fragment/build_fragment_test.js",
                 "can/view/import/import_test.js",
-                "can/util/jquery/jquery_test.js",
                 function() {
                     can.dev.logLevel = 3;
                 });
@@ -65,4 +64,4 @@
     <div id="qunit-fixture"></div>
 </body>
 
-</html>
+</html>
diff --git a/view/bindings/bindings.js b/view/bindings/bindings.js
@@ -347,11 +347,11 @@ steal("can/util", "can/view/stache/expression.js", "can/view/callbacks", "can/co
 						}
 					});
 				} else {
-					if(!options.legacyBindings && hasChildren && ("selectedIndex" in el) && newVal == null) {
+					if(!options.legacyBindings && hasChildren && ("selectedIndex" in el)) {
 						el.selectedIndex = -1;
-					} else {
-						can.attr.setAttrOrProp(el, prop, newVal == null ? "" : newVal);
 					}
+					can.attr.setAttrOrProp(el, prop, newVal == null ? "" : newVal);
+
 
 				}
 				return newVal;