-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Putting a can.compute on a Component scope throws #1086
Comments
A "single" value compute like this will blow up, but why would you use that? A function compute should work just fine. A Component is probably not necessary. You could probably get this with a map:
This probably has to do with compute's clone method. |
That's true, probably no reason to do it this way. One of our existing apps this was working in 2.0.4. |
Tested and this doesn't break on a can.Map. |
This changed from 2.0 to 2.1. Closing this issue as it can be fixed by setting it as a property instead of a value compute as discussed. |
I'm not sure it should be closed. It still technically a bug. |
Ok. Reopening and putting it int 2.1.3. |
This was fixed in a prior merge in minor. Typo in the test, adding @matthewp's test to a PR. |
Will attach a test shortly.
The text was updated successfully, but these errors were encountered: