Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Models with no id (undefined or null) are placed in model store #1358

Closed
wclr opened this issue Dec 6, 2014 · 4 comments
Closed

Models with no id (undefined or null) are placed in model store #1358

wclr opened this issue Dec 6, 2014 · 4 comments
Labels
bug
Milestone
2.2.0

Comments

@wclr
Copy link
Contributor

wclr commented Dec 6, 2014

Is to correct that models with no id (id is undfined, null) are placed in model store?

http://jsfiddle.net/xKc3H/564/

Is it intended behavoiur?
@wclr
Copy link
Contributor Author

wclr commented Dec 13, 2014

Have you checked this issue?

@daffl daffl added the bug label Dec 13, 2014
@daffl
Copy link
Contributor

daffl commented Dec 13, 2014

I could verify that. I don't think it causes any problems directly but we should probably fix it and not add it to the store.

@wclr
Copy link
Contributor Author

wclr commented Dec 14, 2014

I don't think it causes any problems directly

Well it depends. In my case it did.

@daffl daffl added this to the 2.2.0 milestone Dec 15, 2014
@daffl
Copy link
Contributor

daffl commented Dec 15, 2014

Makes sense. Will fix it for the next release.

@daffl daffl changed the title Models with no id (undfined or null) are placed in model store Models with no id (undefined or null) are placed in model store Feb 11, 2015
cklanac added a commit that referenced this issue Feb 12, 2015
@cklanac
Issue #1358 Models with no id should not be placed in store.
a5364c2 
Added test for models with no id and a related test if model is removed after being created. Fix is to check the model id on event binding setup.
@cklanac cklanac mentioned this issue Feb 12, 2015
Merged
@daffl daffl closed this as completed Feb 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.2.0
Development

No branches or pull requests
3 participants
@daffl @wclr @cklanac