New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Models with no id (undefined or null) are placed in model store #1358

Closed
whitecolor opened this Issue Dec 6, 2014 · 4 comments

Comments

Projects
None yet
3 participants
@whitecolor
Contributor

whitecolor commented Dec 6, 2014

Is to correct that models with no id (id is undfined, null) are placed in model store?

http://jsfiddle.net/xKc3H/564/

Is it intended behavoiur?

@whitecolor

This comment has been minimized.

Show comment
Hide comment
@whitecolor

whitecolor Dec 13, 2014

Contributor

Have you checked this issue?

Contributor

whitecolor commented Dec 13, 2014

Have you checked this issue?

@daffl daffl added the bug label Dec 13, 2014

@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl Dec 13, 2014

Contributor

I could verify that. I don't think it causes any problems directly but we should probably fix it and not add it to the store.

Contributor

daffl commented Dec 13, 2014

I could verify that. I don't think it causes any problems directly but we should probably fix it and not add it to the store.

@whitecolor

This comment has been minimized.

Show comment
Hide comment
@whitecolor

whitecolor Dec 14, 2014

Contributor

I don't think it causes any problems directly

Well it depends. In my case it did.

Contributor

whitecolor commented Dec 14, 2014

I don't think it causes any problems directly

Well it depends. In my case it did.

@daffl daffl added this to the 2.2.0 milestone Dec 15, 2014

@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl Dec 15, 2014

Contributor

Makes sense. Will fix it for the next release.

Contributor

daffl commented Dec 15, 2014

Makes sense. Will fix it for the next release.

@daffl daffl changed the title from Models with no id (undfined or null) are placed in model store to Models with no id (undefined or null) are placed in model store Feb 11, 2015

cklanac added a commit that referenced this issue Feb 12, 2015

Issue #1358 Models with no id should not be placed in store.
Added test for models with no id and a related test if model is removed after being created. Fix is to check the model id on event binding setup.

@daffl daffl closed this Feb 13, 2015

@daffl daffl removed the fixed in branch label Feb 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment