Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Events within nested computes #1394

Closed
alexisabril opened this issue Jan 6, 2015 · 5 comments
Closed

Events within nested computes #1394

alexisabril opened this issue Jan 6, 2015 · 5 comments
Assignees
@alexisabril
Labels
bug

Comments

@alexisabril
Copy link
Contributor

Inner computes changing should trigger a change on a compute wrapping it. This is a potential bug or a potential no-fix depending on implementation details/perf considerations.

Real world scenario:

Allowing for helpers that can return a value based on a deferred's state.
alexisabril added a commit that referenced this issue Jan 6, 2015
@alexisabril
adding test for #1394
491617b
@justinbmeyer
Copy link
Contributor

Seems valid.

@justinbmeyer
Copy link
Contributor

@alexisabril maybe we can fix this in can.Compute

@justinbmeyer justinbmeyer added this to the 2.2.0 milestone Feb 11, 2015
@daffl daffl modified the milestones: 2.3.0, 2.2.0 Feb 23, 2015
@daffl
Copy link
Contributor

daffl commented Mar 3, 2015

Is this fixed via #1486?

@daffl daffl modified the milestones: 2.3.0, 2.2.0 Mar 4, 2015
@alexisabril
Copy link
Contributor Author

Just noting this was not fixed via #1486

@daffl daffl removed this from the 2.3.0 milestone Oct 22, 2015
@justinbmeyer justinbmeyer mentioned this issue May 20, 2016
Closed
@justinbmeyer
Copy link
Contributor

Still breaking: http://justinbmeyer.jsbin.com/tinece/5/edit?html,js,output. I think this only happens with computes that are defined and called within a compute: http://jsbin.com/qovipi/edit?html,js,console,output Closing for: canjs/can-compute#7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexisabril alexisabril

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@justinbmeyer @alexisabril @daffl