can.map throws strings, not errors.

[akagomez]

Currently:

throw "can.Map: Object does not exist";

Should be:

throw Error("can.Map: Object does not exist");

https://github.com/bitovi/canjs/blob/master/map/map.js#L495

/cc @imjoshdean

[imjoshdean]

👍 Throwing strings don't provide things like stack traces and other Error goodies that are useful.

[daffl]

👍 But I'm wondering if this could be considered a breaking API change?

[akagomez]

Other instances I found:

./map/define/define_test.js:546:                        throw '"foo"\'s value method should not be called.';
./map/lazy/lazy.js:196:             throw "can.LazyMap: object does not exist";
./map/map.js:495:                       throw "can.Map: Object does not exist";
./util/fixture/fixture.js:108:                  throw "fixtures.js Error " + error + " " + message;
./view/parser/parser.js:236:                throw "Parse Error: " + html;
./view/view.js:46:          throw "can.view: No template or empty template:" + url;

[imjoshdean]

I...don't think so? How would it break the API?

[justinbmeyer]

It would not. We don't document these errors.

[daffl]

Shouldn't it be throw new Error("can.Map: Object does not exist");? Anyway, if it doesn't we can even get it into the 2.2.7 patch release.

[justinbmeyer]

@akagomez can you submit a pull request for this? Thanks!

[imjoshdean]

@justinbmeyer I'm submitting one shortly, with more than just this throwing an error instead of a new string.

[akagomez]

The PR: #1811