Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

global var "GLOBALCAN" fails #2039

Closed
espretto opened this issue Oct 29, 2015 · 4 comments
Closed

global var "GLOBALCAN" fails #2039

espretto opened this issue Oct 29, 2015 · 4 comments
Milestone
2.3.1

Comments

@espretto
Copy link

i'm using the amd variant and was thus looking for a way to avoid canjs' global export. apparently "GLOBALCAN" needs be set to false in tandem with uglify's dead_code option. it works! but not for can/amd/can/view/stache/utils.js which is missing can in its argument list.

i would have annotated the exact code line on github but i couldn't find the amd-build. i guess you're generating that with stealjs so i opened an issue.
@daffl daffl added this to the 2.3.1 milestone Oct 29, 2015
@daffl
Copy link
Contributor

daffl commented Oct 29, 2015

Just working on releasing a 2.3.1 which should fix this via #2021

@daffl daffl closed this as completed Oct 29, 2015
@espretto
Copy link
Author

great! could you do the same for canjs/amd/can/view/mustache.js > window.Mustache?

@daffl
Copy link
Contributor

daffl commented Oct 29, 2015

I wonder why Mustache gets added to the window. I'll add a condition to only do this when GLOBALCAN is true.

@espretto
Copy link
Author

I'm currently upgrading from 2.1.1 to 2.3.1. the global Mustache still leaks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.3.1
Development

No branches or pull requests
2 participants
@daffl @espretto