global var "GLOBALCAN" fails #2039

Closed
espretto opened this Issue Oct 29, 2015 · 4 comments

Comments

Projects
None yet
2 participants
@espretto

i'm using the amd variant and was thus looking for a way to avoid canjs' global export. apparently "GLOBALCAN" needs be set to false in tandem with uglify's dead_code option. it works! but not for can/amd/can/view/stache/utils.js which is missing can in its argument list.

i would have annotated the exact code line on github but i couldn't find the amd-build. i guess you're generating that with stealjs so i opened an issue.

@daffl daffl added this to the 2.3.1 milestone Oct 29, 2015

@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl Oct 29, 2015

Contributor

Just working on releasing a 2.3.1 which should fix this via #2021

Contributor

daffl commented Oct 29, 2015

Just working on releasing a 2.3.1 which should fix this via #2021

@daffl daffl closed this Oct 29, 2015

@espretto

This comment has been minimized.

Show comment
Hide comment
@espretto

espretto Oct 29, 2015

great! could you do the same for canjs/amd/can/view/mustache.js > window.Mustache?

great! could you do the same for canjs/amd/can/view/mustache.js > window.Mustache?

@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl Oct 29, 2015

Contributor

I wonder why Mustache gets added to the window. I'll add a condition to only do this when GLOBALCAN is true.

Contributor

daffl commented Oct 29, 2015

I wonder why Mustache gets added to the window. I'll add a condition to only do this when GLOBALCAN is true.

@espretto

This comment has been minimized.

Show comment
Hide comment
@espretto

espretto Nov 14, 2015

I'm currently upgrading from 2.1.1 to 2.3.1. the global Mustache still leaks.

I'm currently upgrading from 2.1.1 to 2.3.1. the global Mustache still leaks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment