Adding scoped reference to 'can'. Removing dependancy on Global 'can'. #2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,4 +1,4 @@ | |||
| steal("can/list", function (list) { | |||
There was a problem hiding this comment.
In this case, 'list' was referenced but never used. 'can' was not referenced but used.
|
Thanks! |
|
Fixing that last build error, give me a few |
|
I'm not sure what's breaking: https://travis-ci.org/bitovi/canjs/jobs/87143498#L2388 Anyway you an check it out? The easy way is to run: And then open |
|
It looks like can.isPlainObject is defined in https://github.com/bitovi/canjs/blob/master/util/object/isplain/isplain.js#L29 and so the new local scoped can doesn't know what it is. It looks like it's actually only an issue for the tests themselves. Let me try something... |
daffl
added a commit
that referenced
this pull request
Oct 29, 2015
Adding scoped reference to 'can'. Removing dependancy on Global 'can'.
|
Awesome, thank you! |
|
My pleasure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.