Adding scoped reference to 'can'. Removing dependancy on Global 'can'. #2021

Merged
merged 6 commits into from Oct 29, 2015

Conversation

Projects
None yet
3 participants
@Psykoral
Contributor

Psykoral commented Oct 23, 2015

No description provided.

@@ -1,4 +1,4 @@
-steal("can/list", function (list) {

This comment has been minimized.

@Psykoral

Psykoral Oct 23, 2015

Contributor

In this case, 'list' was referenced but never used. 'can' was not referenced but used.

@Psykoral

Psykoral Oct 23, 2015

Contributor

In this case, 'list' was referenced but never used. 'can' was not referenced but used.

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Oct 24, 2015

Contributor

Thanks!

Contributor

justinbmeyer commented Oct 24, 2015

Thanks!

@Psykoral

This comment has been minimized.

Show comment
Hide comment
@Psykoral

Psykoral Oct 24, 2015

Contributor

Fixing that last build error, give me a few

Contributor

Psykoral commented Oct 24, 2015

Fixing that last build error, give me a few

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Oct 24, 2015

Contributor

I'm not sure what's breaking: https://travis-ci.org/bitovi/canjs/jobs/87143498#L2388

Anyway you an check it out?

The easy way is to run:

grunt testify

And then open test/amd/jquery-2.html and see if that's breaking in the browser.

Contributor

justinbmeyer commented Oct 24, 2015

I'm not sure what's breaking: https://travis-ci.org/bitovi/canjs/jobs/87143498#L2388

Anyway you an check it out?

The easy way is to run:

grunt testify

And then open test/amd/jquery-2.html and see if that's breaking in the browser.

@Psykoral

This comment has been minimized.

Show comment
Hide comment
@Psykoral

Psykoral Oct 24, 2015

Contributor

It looks like can.isPlainObject is defined in https://github.com/bitovi/canjs/blob/master/util/object/isplain/isplain.js#L29 and so the new local scoped can doesn't know what it is. It looks like it's actually only an issue for the tests themselves. Let me try something...

Contributor

Psykoral commented Oct 24, 2015

It looks like can.isPlainObject is defined in https://github.com/bitovi/canjs/blob/master/util/object/isplain/isplain.js#L29 and so the new local scoped can doesn't know what it is. It looks like it's actually only an issue for the tests themselves. Let me try something...

@Psykoral

This comment has been minimized.

Show comment
Hide comment

@daffl daffl added this to the 2.3.1 milestone Oct 26, 2015

daffl added a commit that referenced this pull request Oct 29, 2015

Merge pull request #2021 from Psykoral/master
Adding scoped reference to 'can'. Removing dependancy on Global 'can'.

@daffl daffl merged commit 8c8ca6d into canjs:master Oct 29, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl Oct 29, 2015

Contributor

Awesome, thank you!

Contributor

daffl commented Oct 29, 2015

Awesome, thank you!

@Psykoral

This comment has been minimized.

Show comment
Hide comment
@Psykoral

Psykoral Oct 29, 2015

Contributor

My pleasure!

Contributor

Psykoral commented Oct 29, 2015

My pleasure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment