Importing a template doesn't work with the new syntax #2042
Comments
matthewp
added a commit
that referenced
this issue
Oct 29, 2015
|
4b3402c contains tests. |
matthewp
added a commit
that referenced
this issue
Oct 30, 2015
This updates all of the can-import tests to use the new binding syntax.
One of the tests uses this method:
```handlebars
<can-import from='can/view/import/test/other.stache!' {^@value}='*other'
/>
{{{*other()}}}
```
While all of the others use the old syntax:
```handlebars
<can-import from='can/view/import/test/other.stache!' {^@value}='*other'
/>
{{> *other}}
```
So we know that both do work.
One change I had to make was to prevent can.Component from setting up
it's own bindings when can-import is used with `can-tag`. This is
because the bindings are performed in can/view/bindings instead.
Closes #2042 and #2044
matthewp
added a commit
that referenced
this issue
Oct 30, 2015
This updates all of the can-import tests to use the new binding syntax.
One of the tests uses this method:
```handlebars
<can-import from='can/view/import/test/other.stache!' {^@value}='*other'
/>
{{{*other()}}}
```
While all of the others use the old syntax:
```handlebars
<can-import from='can/view/import/test/other.stache!' {^@value}='*other'
/>
{{> *other}}
```
So we know that both do work.
One change I had to make was to prevent can.Component from setting up
it's own bindings when can-import is used with `can-tag`. This is
because the bindings are performed in can/view/bindings instead.
Closes #2042 and #2044
|
@matthewp Can you make the changes we talked about on Friday tomorrow? I'd like to get 2.3.2 done. Thanks! |
matthewp
added a commit
that referenced
this issue
Nov 9, 2015
matthewp
added a commit
that referenced
this issue
Nov 9, 2015
This updates all of the can-import tests to use the new binding syntax.
One of the tests uses this method:
```handlebars
<can-import from='can/view/import/test/other.stache!' {^@value}='*other'
/>
{{{*other()}}}
```
While all of the others use the old syntax:
```handlebars
<can-import from='can/view/import/test/other.stache!' {^@value}='*other'
/>
{{> *other}}
```
So we know that both do work.
One change I had to make was to prevent can.Component from setting up
it's own bindings when can-import is used with `can-tag`. This is
because the bindings are performed in can/view/bindings instead.
Closes #2042 and #2044
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Tries to import
*other.mustache, not sure why yet.The text was updated successfully, but these errors were encountered: