Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

%index doesn't work with can.Map values in master #2067

Closed
akagomez opened this issue Nov 9, 2015 · 3 comments · Fixed by #2082
Closed

%index doesn't work with can.Map values in master #2067

akagomez opened this issue Nov 9, 2015 · 3 comments · Fixed by #2082
Labels
bug fixed in branch
Milestone
2.3.3

Comments

@akagomez
Copy link
Contributor

akagomez commented Nov 9, 2015

The {{(at)index}} stache helper/keyword will not render an index if the value at that index is a map.

See: http://jsbin.com/qogafo/edit?html,js,output
@akagomez akagomez changed the title @index doesn't work in with can.Map values in master @index doesn't work with can.Map values in master Nov 9, 2015
@pYr0x
Copy link

pYr0x commented Nov 10, 2015

should {{@index}} not be replaced by {{%index}} ?
http://canjs.com/docs/can.stache.key.html

@akagomez
Copy link
Contributor Author

Maybe. Didn't work for me though.

@justinbmeyer
Copy link
Contributor

It should be %index, but work both ways for now.

@justinbmeyer justinbmeyer changed the title @index doesn't work with can.Map values in master %index doesn't work with can.Map values in master Nov 12, 2015
@justinbmeyer justinbmeyer added this to the 2.3.3 milestone Nov 12, 2015
justinbmeyer added a commit that referenced this issue Nov 13, 2015
@justinbmeyer
fixes #2067 and #1554
68f7e92
@justinbmeyer justinbmeyer mentioned this issue Nov 13, 2015
Merged
justinbmeyer added a commit that referenced this issue Nov 30, 2015
@justinbmeyer @daffl
fixes #2067 and #1554
3ab934c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug fixed in branch
Projects
None yet
Milestone
2.3.3
Development

Successfully merging a pull request may close this issue.

Makes %index work when a list has observables and makes ../ skip noContext scopes right. canjs/canjs
3 participants
@justinbmeyer @akagomez @pYr0x