Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stache system plugin needs nodeList #2166

Closed
alexisabril opened this issue Jan 4, 2016 · 1 comment
Closed

stache system plugin needs nodeList #2166

alexisabril opened this issue Jan 4, 2016 · 1 comment
Assignees
Labels
Milestone

Comments

@alexisabril
Copy link
Contributor

https://github.com/canjs/canjs/blob/master/view/stache/system.js#L26

nodeList needs to be passed in as an argument on L26, then passed in the returned function on L31.

Pseudo-test case is:

var nl = [];

//note: we'll need to import a template to test the stache! plugin
//create template with above node list set manually

//register helper, should receive above node list; currently this does not
can.stache.registerHelper('helper', function(options) {
    equal(options.nodeList, nl)
});
@alexisabril alexisabril self-assigned this Jan 4, 2016
alexisabril pushed a commit that referenced this issue Jan 4, 2016
@alexisabril
Copy link
Contributor Author

Note: this issue needs a test

alexisabril pushed a commit that referenced this issue Jan 5, 2016
alexisabril pushed a commit that referenced this issue Jan 5, 2016
alexisabril pushed a commit that referenced this issue Jan 5, 2016
mjstahl pushed a commit that referenced this issue Jan 11, 2016
mjstahl pushed a commit that referenced this issue Jan 11, 2016
Fixed url to test file
@daffl daffl added this to the 2.3.9 milestone Jan 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants