routeUrl helper, merge option not working

[gmahomarf]

I'm trying to use {{routeUrl(page='home', true)}} to change only the page attribute in my route, but it's not working. Debugging shows that when we call the helper @here, params is true and merge is the options object, as defined in the stache helpers docs. Shouldn't those arguments be inverted, so that they match the documentation (i.e. all arguments first, then options object with hash)?

[justinbmeyer]

When you use a call expression, there really shouldn't be an options object.

Instead page='home' should pass an object like {page: "home"} as the first argument and true as the second.

[gmahomarf]

I'll try it, thanks. I was using a call expression as detailed in the routeUrl helper docs. They should be updated.

[justinbmeyer]

@gmahomarf I'm a bit confused. Does it not work the way I suggested in my comment?

If yes, then this is a bug, not a problem with the docs.

[gmahomarf]

@justinbmeyer just to be clear, you're suggesting I do the following?:

<a href="{{routeUrl({page: 'home'}, true)}}"> Link</a>

[gmahomarf]

@justinbmeyer I ran several tests this morning. Each example has the stache template where routeUrl was used. Below that are values of the arguments sent to the routeUrl helper (see code) and the resulting value for the href attribute.

To avoid cluttering the issue comments, I created a gist with the results: https://gist.github.com/gmahomarf/92d97265694f0c1a77ec

I hope this helps

[gmahomarf]

Any news on this?

[justinbmeyer]

Canjs is not a priority for me this week. I'm working on can-set issues currently. If you want to help fix it, I can pair with you this week and close it out. Otherwise it will probably have to wait until next week.

Sent from my iPhone

On Feb 29, 2016, at 5:46 PM, Gazy Mahomar notifications@github.com wrote:

Any news on this?

—
Reply to this email directly or view it on GitHub.

[gmahomarf]

@justinbmeyer For now, I've got my code working as I need it, so this is no longer urgent for me. Ping me whenever you have time to take a look at this, and I'd love to help fix it. Thanks!