Twitter Bower component of CanJS #252

Closed
renandeazevedo opened this Issue Jan 23, 2013 · 14 comments

Comments

Projects
None yet
5 participants
@renandeazevedo

I have seen most Bower components have just the build files and while installing CanJS thought it, I got a clone of the master branch or something similar, with all the sources, tests and none of built files.

Due to that I downloaded the package on http://canjs.us/ and created a repo to use it in the meanwhile, wich you can see in https://github.com/renanra/bower-canjs/.

It would be great having a branch to build the sources and having a updated component.json(version is outdated on master branch).

@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl Jan 23, 2013

Contributor

Yes, I think a download branch with the built files would be a solution especially now that GitHub got rid of the download functionality anyway. The way you can currently get everything from Bower isn't very helpful anyway (because you can't even build without additional repositories).

Contributor

daffl commented Jan 23, 2013

Yes, I think a download branch with the built files would be a solution especially now that GitHub got rid of the download functionality anyway. The way you can currently get everything from Bower isn't very helpful anyway (because you can't even build without additional repositories).

@ecentinela

This comment has been minimized.

Show comment
Hide comment
@ecentinela

ecentinela Feb 7, 2013

+1 for Bower compatibility

+1 for Bower compatibility

@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl Mar 5, 2013

Contributor

The problem is that we can't just point to the main repository. We'd need some branch that includes all the build files (pretty much what's in the download). Is there a way to specifiy a branch for Bower?

Contributor

daffl commented Mar 5, 2013

The problem is that we can't just point to the main repository. We'd need some branch that includes all the build files (pretty much what's in the download). Is there a way to specifiy a branch for Bower?

@ecentinela

This comment has been minimized.

Show comment
Hide comment
@ecentinela

ecentinela Mar 5, 2013

I don't know, but is really a problem. More and more libraries are being available from bower. CanJS should be too, to reach a bigger portion of developers.

I don't know, but is really a problem. More and more libraries are being available from bower. CanJS should be too, to reach a bigger portion of developers.

@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl Mar 5, 2013

Contributor

There is a component.json in Can. But since Bower just copies the repository contents at the given version this will be pretty useless unless you are using Steal.

Contributor

daffl commented Mar 5, 2013

There is a component.json in Can. But since Bower just copies the repository contents at the given version this will be pretty useless unless you are using Steal.

@ecentinela

This comment has been minimized.

Show comment
Hide comment
@ecentinela

ecentinela Mar 5, 2013

How is this being done by jquery team?

How is this being done by jquery team?

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Mar 6, 2013

Contributor

If you figure it out, we'd accept a patch setting this up for canjs.

On Mar 5, 2013, at 5:51 PM, Javier Martinez Fernandez notifications@github.com wrote:

How is this being done by jquery team?


Reply to this email directly or view it on GitHub.

Contributor

justinbmeyer commented Mar 6, 2013

If you figure it out, we'd accept a patch setting this up for canjs.

On Mar 5, 2013, at 5:51 PM, Javier Martinez Fernandez notifications@github.com wrote:

How is this being done by jquery team?


Reply to this email directly or view it on GitHub.

@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl Mar 6, 2013

Contributor

They are cheating. All the fancy stuff gets cloned from the components organization.

Contributor

daffl commented Mar 6, 2013

They are cheating. All the fancy stuff gets cloned from the components organization.

@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl Mar 6, 2013

Contributor

Ok, you can now

bower install canjs

With the latest 1.1.4 version and you pretty much get the same content (different builds and AMD version) than in the download. Needs to update the repository and make updating it part of the deployment process.

Contributor

daffl commented Mar 6, 2013

Ok, you can now

bower install canjs

With the latest 1.1.4 version and you pretty much get the same content (different builds and AMD version) than in the download. Needs to update the repository and make updating it part of the deployment process.

@ecentinela

This comment has been minimized.

Show comment
Hide comment
@ecentinela

ecentinela Mar 6, 2013

Thanks @daffl, it works perfectly!

Thanks @daffl, it works perfectly!

@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl Mar 13, 2013

Contributor

For the 1.2 release we need to change the repository and make it part of the Grunt 0.4 build.

Contributor

daffl commented Mar 13, 2013

For the 1.2 release we need to change the repository and make it part of the Grunt 0.4 build.

@passy

This comment has been minimized.

Show comment
Hide comment
@passy

passy Mar 16, 2013

The bower component for 1.1.4 works great, we're already using it for TodoMVC. Do you have a plan on how to handle the optional plugins? It would if I could install canjs-mustache as a separate package for example.

passy commented Mar 16, 2013

The bower component for 1.1.4 works great, we're already using it for TodoMVC. Do you have a plan on how to handle the optional plugins? It would if I could install canjs-mustache as a separate package for example.

@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl Mar 19, 2013

Contributor

That's exactly what we should do. At the moment they just all come with the package (which doesn't matter too much if you aren't using them) but I'd really like to get all the plugins out of the main repository anyway.

Contributor

daffl commented Mar 19, 2013

That's exactly what we should do. At the moment they just all come with the package (which doesn't matter too much if you aren't using them) but I'd really like to get all the plugins out of the main repository anyway.

@passy passy referenced this issue in tastejs/todomvc Mar 19, 2013

Closed

Use Bower for dependency management #475

22 of 57 tasks complete

@ghost ghost assigned daffl May 7, 2013

@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl May 23, 2013

Contributor

Bower endpoint now fixed and correctly pointing to the new distributable repository so we can easily update it in the future.

Contributor

daffl commented May 23, 2013

Bower endpoint now fixed and correctly pointing to the new distributable repository so we can easily update it in the future.

@daffl daffl closed this May 23, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment