Execute startBatch callbacks #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build failed, I think in your new tests. Could you merge with latest master and re-run the full test suite ( |
|
I had the wrong expected assertions count. I forgot I removed a change to the observe before committing the test and never decremented the expected assertions count. Should be good now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The callbacks passed in to startBatch were not being called.
Updated the existing startBatch/stopBatch test. There was an assertion in there for callbacks, but since the callback wasn't being executed, the assertion was not being run. I updated that test to expect the total number of assertions.
I also added a small test that makes sure the callback is executed