-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.0.4 Live @index still not working correctly #640
Comments
By "it" you mean some other case than the one tested in cb849f3 ? |
This seems to be related to using partials: |
By "it", I mean: "Index: 0 Parent: | Item 0" That one doesn't delete, and then all the indexes above it decrement. Not to mention, it worked when I just applied that one patch as can be seen in http://jsfiddle.net/subsonic/6v6nz/ |
@AdamTourkow After looking at this fiddle for a bit, I hope this is just an example and your code does not work like this. |
Here's a minimal breaking example: http://jsfiddle.net/j9ZBw/7/ |
It seems there is a difference between how the partial is found. http://jsfiddle.net/j9ZBw/9/ breaks, but if you change:
to
It works. My bet is that this is due to a bug with renderer functions not actually being renderer functions. |
Nope, seems to be due to to reading a partial in can.view.render.txt being "compute-itized" .... |
There was a pending fix to live binding in commit:
cb849f3
While waiting for the fix to reach release I hand modified the changes into my js which worked:
http://subsonic-systems.com/misc/can.custom_modifed_by_me.js
Modifed 2.0.3 code: http://jsfiddle.net/subsonic/6v6nz/
When using the 2.0.4 code, it still doesn't work.
Current 2.0.4 code: http://jsfiddle.net/subsonic/j9ZBw/
Steps to reproduce:
Expected:
When deleting first element/node index should be deleted correctly.
The text was updated successfully, but these errors were encountered: