Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add warning when component attribute is ignored #975

Closed
moschel opened this issue May 8, 2014 · 0 comments · Fixed by #976
Closed

add warning when component attribute is ignored #975

moschel opened this issue May 8, 2014 · 0 comments · Fixed by #976
Labels
documentation
Milestone
2.1.1

Comments

@moschel
Copy link
Contributor

moschel commented May 8, 2014

If someone tries to do (thinking "id" will be the new scope property for productId)

<my-thing id='{productId}'></my-tagged>

It will fail silently because id and class can't be used as scope attributes. I've made this mistake and it stumped me for a while. We should add a warning. This was @matthewp 's idea.
moschel added a commit that referenced this issue May 8, 2014
@moschel
#975 add warning when component fails silently
07aaa46
@moschel moschel mentioned this issue May 8, 2014
Merged
@ccummings ccummings added this to the 2.1.1 milestone May 16, 2014
gsmeets pushed a commit to gsmeets/canjs that referenced this issue Aug 15, 2014
@moschel
canjs#975 add warning when component fails silently
141edf2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
2.1.1
Development

Successfully merging a pull request may close this issue.

Component warn canjs/canjs
2 participants
@moschel @ccummings