New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering of <col> inside <table> in templates. #1013

Merged
merged 1 commit into from Jun 10, 2014

Conversation

Projects
None yet
2 participants
@asavoy
Contributor

asavoy commented May 23, 2014

Please refer to this fiddle which demonstrates that <col> tags end up being rendered outside <table>. The clue was that live-binding triggers the messed up rendering. The attached patch fixes this behavior.

See HTML5 spec regarding the <colgroup> element and the <col> element, the main take-away being that <col> should be within <colgroup> which should be within <table>.

@daffl daffl added this to the 2.1.2 milestone May 27, 2014

daffl added a commit that referenced this pull request Jun 10, 2014

Merge pull request #1013 from asavoy/support-col-colgroup
Fix rendering of <col> inside <table> in templates.

@daffl daffl merged commit 595e907 into canjs:master Jun 10, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

daffl added a commit that referenced this pull request Jun 10, 2014

@asavoy asavoy deleted the asavoy:support-col-colgroup branch Jun 11, 2014

@daffl daffl modified the milestones: 2.1.4, 2.1.2 Oct 27, 2014

daffl added a commit that referenced this pull request Nov 3, 2014

daffl added a commit that referenced this pull request Nov 3, 2014

daffl added a commit that referenced this pull request Nov 3, 2014

daffl added a commit that referenced this pull request Nov 3, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment