Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model.resource is not working with inherited classes #1089

Merged
merged 2 commits into from
Jul 10, 2014
Merged

Model.resource is not working with inherited classes #1089

merged 2 commits into from
Jul 10, 2014

Conversation

alexisabril
Copy link
Contributor

I have modified example Todo fiddle to show that if Model is inherited from some base class, resource property does not work.

http://jsfiddle.net/prinzC/xKc3H/386/

var BaseTodo = can.Model.extend({})

var Todo = BaseTodo.extend({
    resource: '/todos'
}, {});

@wclr wclr changed the title Model resource is not working with inherited classes Model.resource is not working with inherited classes Jun 16, 2014
alexisabril added a commit that referenced this pull request Jun 27, 2014
@alexisabril
adding test & fix for issue #1089
ee349fe
@alexisabril alexisabril added this to the 2.1.3 milestone Jun 27, 2014
alexisabril pushed a commit that referenced this pull request Jun 29, 2014
adding test for clobbering CRUD overrides when using resource #1089
4beda53
@alexisabril
Copy link
Contributor

@justinbmeyer Good call. I added an additional test and modified the condition to which we call ajaxMaker.

alexisabril pushed a commit that referenced this pull request Jul 1, 2014
proper logic to handle functions, strings, objects and overrides with…
241cb81 
… resource #1089
alexisabril pushed a commit that referenced this pull request Jul 1, 2014
additional docs for #1089
c314524
alexisabril pushed a commit that referenced this pull request Jul 1, 2014
conflicting fixture #1089
5d18b80
alexisabril pushed a commit that referenced this pull request Jul 2, 2014
simplifying the condition checking for object overrides. #1089
4264a70
alexisabril and others added 2 commits July 9, 2014 12:32
@alexisabril
adding test & fix for issue #1089
54a2107 
adding test for clobbering CRUD overrides when using resource #1089

proper logic to handle functions, strings, objects and overrides with resource #1089

additional docs for #1089

conflicting fixture #1089

simplifying the condition checking for object overrides. #1089
MERGECONFLICT for #1089 & 1074 in model_test.js
18f3f40
daffl added a commit that referenced this pull request Jul 10, 2014
@daffl
Merge pull request #1089 from bitovi/1089-resource
277f23b 
Model.resource is not working with inherited classes
@daffl daffl merged commit 277f23b into master Jul 10, 2014
@daffl daffl deleted the 1089-resource branch July 10, 2014 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexisabril alexisabril

Labels
bug
Projects
None yet
Milestone
2.1.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexisabril @daffl