Model.resource is not working with inherited classes #1089

Merged
merged 2 commits into from Jul 10, 2014

Conversation

Projects
None yet
2 participants
@alexisabril
Contributor

alexisabril commented Jun 27, 2014

I have modified example Todo fiddle to show that if Model is inherited from some base class, resource property does not work.

http://jsfiddle.net/prinzC/xKc3H/386/

var BaseTodo = can.Model.extend({})

var Todo = BaseTodo.extend({
    resource: '/todos'
}, {});

@whitecolor whitecolor changed the title from Model resource is not working with inherited classes to Model.resource is not working with inherited classes Jun 16, 2014

@alexisabril alexisabril added the Bug label Jun 26, 2014

alexisabril added a commit that referenced this pull request Jun 27, 2014

@alexisabril alexisabril added this to the 2.1.3 milestone Jun 27, 2014

@alexisabril

This comment has been minimized.

Show comment
Hide comment
@alexisabril

alexisabril Jun 29, 2014

Contributor

@justinbmeyer Good call. I added an additional test and modified the condition to which we call ajaxMaker.

Contributor

alexisabril commented Jun 29, 2014

@justinbmeyer Good call. I added an additional test and modified the condition to which we call ajaxMaker.

alexisabril pushed a commit that referenced this pull request Jul 1, 2014

alexisabril pushed a commit that referenced this pull request Jul 1, 2014

alexisabril and others added some commits Jun 27, 2014

adding test & fix for issue #1089
adding test for clobbering CRUD overrides when using resource #1089

proper logic to handle functions, strings, objects and overrides with resource #1089

additional docs for #1089

conflicting fixture #1089

simplifying the condition checking for object overrides. #1089

daffl added a commit that referenced this pull request Jul 10, 2014

Merge pull request #1089 from bitovi/1089-resource
Model.resource is not working with inherited classes

@daffl daffl merged commit 277f23b into master Jul 10, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@daffl daffl deleted the 1089-resource branch Jul 10, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment