Corrected pushstate tests and update can.test.route #1098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramblinjan
changed the title
| stop(); | ||
| makeTestingIframe(function(info, done){ | ||
| info.route.bindings.pushstate.root = "/"; | ||
| info.route.bindings.pushstate.root = can.test.path("route/pushstate/testing.html", true).replace("route/pushstate/testing.html", ""); |
There was a problem hiding this comment.
Isn't can.test.path("route/pushstate/testing.html", true).replace("route/pushstate/testing.html", ""); the same as can.test.path("")?
There was a problem hiding this comment.
I think steal adds a .js to ""
Sent from my iPhone
On Jun 19, 2014, at 4:01 PM, David Luecke notifications@github.com wrote:
In route/pushstate/pushstate_test.js:
stop(); makeTestingIframe(function(info, done){
info.route.bindings.pushstate.root = "/";info.route.bindings.pushstate.root = can.test.path("route/pushstate/testing.html", true).replace("route/pushstate/testing.html", "");—
Reply to this email directly or view it on GitHub.
There was a problem hiding this comment.
Even to something ending with /?
daffl
added a commit
that referenced
this pull request
Jul 8, 2014
Corrected pushstate tests and update can.test.route
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes pushstate domain tests to run properly.
can.test.pathwill adjust the root path depending on whether tests have access to steal.