Don't show a warning if a helper method is used in mustache #1306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why is missing keys not used? Is there a test? |
daffl
force-pushed
the
dont-show-helper-warnings
branch
2 times, most recently
from
db2612a
to
6822b58
Compare
daffl
added a commit
that referenced
this pull request
Nov 14, 2014
Don't show a warning if a helper method is used in mustache
|
Will it be merge in minor? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1257
Don't show any can.dev.warn message if a Mustache helper method is accessed.
Can see this in action if you run http://localhost:8000/view/mustache/test.html and comment out can.dev.logLevel = 3. Before the change, you'll see many warnings about helper methods, but none after.