missing dependency to can/model

[dimaf]

in my case this missing dependency is causing that model instances, unless "'can/model'" explicitly stealed before validations.js, do not have validations

i see you have this comment in attibutes.js

// in some cases model might not be defined quite yet.
    if(clss === undefined){
        return;
    }

but was there a reason for not including dependency to can/model instead of that comment?

[justinbmeyer]

validations does not depend on model, only on observe. It should be adding this functionality to Model similar to how attributes adds itself to model and observe.

[justinbmeyer]

The following works for me

steal('can/model').then('can/observe/validations',function(){
        var Person = can.Model({
            init: function(){
                this.validate("birthday",function(birthday){
                        if(birthday > new Date){
                            return "your birthday needs to be in the past"
                        }
                    })
            }
        },{});
        var p = new Person({birthday: new Date(new Date().getTime()+1000 )});
        console.log( p.errors() );
    })

[justinbmeyer]

ah, that was what you said should work ...

[dimaf]

exactly that will work..
but from what i see in validations.js line 62
https://github.com/jupiterjs/canjs/blob/master/observe/validations/validations.js#L62

can.each([ can.Observe, can.Model ], function(clss){

it does use can.Model hence needs to have dependency to model.js right?

so I was wondering why you have not included the dependency to Model and instead added this

// in some cases model might not be defined quite yet.
    if(clss === undefined){
        return;
    }