Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Our views aren't updating #151

Closed
wants to merge 1 commit into from
Closed

Our views aren't updating #151

wants to merge 1 commit into from

Conversation

cohuman
Copy link
Contributor

@cohuman cohuman commented Nov 13, 2012

Because the observes are getting disconnected - see the test

@ghost ghost assigned imjoshdean Nov 14, 2012
@justinbmeyer
Copy link
Contributor

Josh, this likely broke when we made those "Observe.prototype.attr replaces observes" changes. But it should make sure it merges normal objects.

Can we get this fixed right away and get out a 1.1.1?

@imjoshdean
Copy link
Contributor

If you don't want to make a new observe out of the mix, with the example you wrote, you can do state.attr({properties:{brand:[]}}); and it won't hammer out the old observable with a new one. This'll be in the latest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants