Adding viewModel to Components control instance #1528

Merged
merged 4 commits into from Mar 17, 2015

Conversation

Projects
None yet
2 participants
@ccummings
Contributor

ccummings commented Mar 17, 2015

This enables you to use this.viewModel inside of a Component like you can use this.scope today.

This didn't fail any tests because they are all using the deprecated this.scope.

@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl Mar 17, 2015

Contributor

Can you change some of the tests so that both are covered? I really thought I caught this one but I guess I didn't.

Contributor

daffl commented Mar 17, 2015

Can you change some of the tests so that both are covered? I really thought I caught this one but I guess I didn't.

daffl added a commit that referenced this pull request Mar 17, 2015

Merge pull request #1528 from bitovi/add-viewModel-to-component-instance
Adding viewModel to Components control instance

@daffl daffl merged commit b19f79a into master Mar 17, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@daffl daffl deleted the add-viewModel-to-component-instance branch Mar 17, 2015

@daffl daffl added this to the 2.2.1 milestone Mar 24, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment