New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow comporator fn return any negative value #1601

Merged
merged 1 commit into from Apr 21, 2015

Conversation

Projects
None yet
2 participants
@whitecolor
Contributor

whitecolor commented Apr 3, 2015

comporator functions should be allowed to return any value less then zero not only -1

allow comporator fn return any negative value
comporator functions should be allowed to return any value less then zero not only -1
@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl Apr 7, 2015

Contributor

This makes sense. Is there a way we can test it?

Contributor

daffl commented Apr 7, 2015

This makes sense. Is there a way we can test it?

@whitecolor

This comment has been minimized.

Show comment
Hide comment
@whitecolor

whitecolor Apr 7, 2015

Contributor

are the exiting tests passing? from my perspective there should be no problem as we just replace == -1 with < 0

Contributor

whitecolor commented Apr 7, 2015

are the exiting tests passing? from my perspective there should be no problem as we just replace == -1 with < 0

@daffl daffl added this to the 2.2.5 milestone Apr 15, 2015

daffl added a commit that referenced this pull request Apr 21, 2015

Merge pull request #1601 from whitecolor/patch-2
allow comporator fn return any negative value

@daffl daffl merged commit c7c9e6f into canjs:master Apr 21, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment