Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document setting context of Stache data helper #1640

Closed
wants to merge 1 commit into from

Conversation

marshallswain
Copy link
Member

As mentioned in #1619, this documents setting the context of the data helper explicitly.

Does the "optional argument" syntax work in that @Signature?

Closes #1619

As mentioned in canjs#1619, this documents setting the context of the data helper explicitly.

Does the "optional argument" syntax work in that @Signature?
@daffl
Copy link
Contributor

daffl commented May 1, 2015

Isn't context here more the data that are being set?

@marshallswain
Copy link
Member Author

I might misunderstand how it works. I thought the optional argument was to allow setting another key as an alternative to the current scope. Maybe it should just say key instead of context?

@daffl
Copy link
Contributor

daffl commented May 11, 2015

Well I mean basically what you do with <div {{data 'person' person2}}> is $(div).data('person', person2) so it's simply just the value that you are setting. I find the word context potentially confusing here.

@alexisabril
Copy link
Contributor

This was fixed by commit b7c8769

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing context in a Stache template breaks the data helper
3 participants