Document setting context of Stache data helper #1640

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@marshallswain
Member

marshallswain commented Apr 23, 2015

As mentioned in #1619, this documents setting the context of the data helper explicitly.

Does the "optional argument" syntax work in that @Signature?

Closes #1619

Document setting context of Stache data helper
As mentioned in #1619, this documents setting the context of the data helper explicitly.

Does the "optional argument" syntax work in that @Signature?
@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl May 1, 2015

Contributor

Isn't context here more the data that are being set?

Contributor

daffl commented May 1, 2015

Isn't context here more the data that are being set?

@marshallswain

This comment has been minimized.

Show comment
Hide comment
@marshallswain

marshallswain May 1, 2015

Member

I might misunderstand how it works. I thought the optional argument was to allow setting another key as an alternative to the current scope. Maybe it should just say key instead of context?

Member

marshallswain commented May 1, 2015

I might misunderstand how it works. I thought the optional argument was to allow setting another key as an alternative to the current scope. Maybe it should just say key instead of context?

@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl May 11, 2015

Contributor

Well I mean basically what you do with <div {{data 'person' person2}}> is $(div).data('person', person2) so it's simply just the value that you are setting. I find the word context potentially confusing here.

Contributor

daffl commented May 11, 2015

Well I mean basically what you do with <div {{data 'person' person2}}> is $(div).data('person', person2) so it's simply just the value that you are setting. I find the word context potentially confusing here.

@alexisabril

This comment has been minimized.

Show comment
Hide comment
@alexisabril

alexisabril Sep 15, 2015

Contributor

This was fixed by commit b7c8769

Contributor

alexisabril commented Sep 15, 2015

This was fixed by commit b7c8769

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment