Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1862. Objects with addEventListener now bindable #1868

Merged
merged 1 commit into from
Oct 22, 2015

Conversation

mjstahl
Copy link
Contributor

@mjstahl mjstahl commented Aug 27, 2015

No description provided.

@mjstahl mjstahl added this to the 2.3.0 milestone Aug 27, 2015
@mjstahl mjstahl force-pushed the 1862-addeventlistener-now-bindable branch from 0c13712 to 0805c85 Compare August 27, 2015 15:52
@mjstahl mjstahl modified the milestones: 2.2.8, 2.3.0 Sep 1, 2015
@mjstahl mjstahl force-pushed the 1862-addeventlistener-now-bindable branch 5 times, most recently from a869bea to 8711de4 Compare September 2, 2015 14:57
@daffl
Copy link
Contributor

daffl commented Sep 3, 2015

Do we know why the tests are failing? It looks like the AMD build isn't working.

@mjstahl
Copy link
Contributor Author

mjstahl commented Sep 4, 2015

I have no idea what is happening. Everything I change makes no difference to the tests passing.

@daffl daffl modified the milestones: 2.3.0, 2.2.8 Sep 11, 2015
@mjstahl mjstahl force-pushed the 1862-addeventlistener-now-bindable branch from 8711de4 to 9e5dc08 Compare September 17, 2015 16:33
…dEventListener

Added tests

Moved new jquery tests to top-level test script

Made test async

Use stop/start instead of assert.async

Moved test file out of all tests and into jquery tests

Fix QUnit undefined global error

Added the test to just the jquery packages

Removed jquery tests from util test collection

Removed from top-level tests because it may be platform-independant
@mjstahl mjstahl force-pushed the 1862-addeventlistener-now-bindable branch from 9e5dc08 to 1b613db Compare September 17, 2015 16:38
daffl added a commit that referenced this pull request Oct 22, 2015
Fixes #1862. Objects with addEventListener now bindable
@daffl daffl merged commit f62e2f4 into minor Oct 22, 2015
@daffl daffl deleted the 1862-addeventlistener-now-bindable branch October 22, 2015 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants