New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1862. Objects with addEventListener now bindable #1868

Merged
merged 1 commit into from Oct 22, 2015

Conversation

Projects
None yet
2 participants
@mjstahl
Member

mjstahl commented Aug 27, 2015

No description provided.

@mjstahl mjstahl modified the milestones: 2.3.0, 2.2.8 Aug 27, 2015

@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl Sep 3, 2015

Contributor

Do we know why the tests are failing? It looks like the AMD build isn't working.

Contributor

daffl commented Sep 3, 2015

Do we know why the tests are failing? It looks like the AMD build isn't working.

@mjstahl

This comment has been minimized.

Show comment
Hide comment
@mjstahl

mjstahl Sep 4, 2015

Member

I have no idea what is happening. Everything I change makes no difference to the tests passing.

Member

mjstahl commented Sep 4, 2015

I have no idea what is happening. Everything I change makes no difference to the tests passing.

@daffl daffl modified the milestones: 2.3.0, 2.2.8 Sep 11, 2015

Fixes #1862. Bindable elements now include those objects that have ad…
…dEventListener

Added tests

Moved new jquery tests to top-level test script

Made test async

Use stop/start instead of assert.async

Moved test file out of all tests and into jquery tests

Fix QUnit undefined global error

Added the test to just the jquery packages

Removed jquery tests from util test collection

Removed from top-level tests because it may be platform-independant

daffl added a commit that referenced this pull request Oct 22, 2015

Merge pull request #1868 from bitovi/1862-addeventlistener-now-bindable
Fixes #1862. Objects with addEventListener now bindable

@daffl daffl merged commit f62e2f4 into minor Oct 22, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@daffl daffl deleted the 1862-addeventlistener-now-bindable branch Oct 22, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment