Optimize sort plugin inserts (#1883) #1927

Merged
merged 1 commit into from Sep 29, 2015

Conversation

Projects
None yet
2 participants
@akagomez
Contributor

akagomez commented Sep 16, 2015

  • Use binary search for _getInsertIndex
  • Fix benchmarks.js
  • Add benchmark(s)
  • Add test

Notes associated with the original PR can be found here: #1895

test/benchmarks.js
@@ -26,7 +26,8 @@ steal("benchmark", function(){
return suite.on.apply(this, arguments)
}
};
- steal().done().then(function(){
+
+ steal().then(function(){

This comment has been minimized.

@daffl

daffl Sep 29, 2015

Contributor

I'm pretty sure this shouldn't use .then

@daffl

daffl Sep 29, 2015

Contributor

I'm pretty sure this shouldn't use .then

Optimize sort plugin inserts (#1883)
- Use binary search for _getInsertIndex
- Fix benchmarks.js
- Add benchmark(s)
- Add test

@daffl daffl added this to the 2.3.0 milestone Sep 29, 2015

daffl added a commit that referenced this pull request Sep 29, 2015

@daffl daffl merged commit e21464d into minor Sep 29, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@daffl daffl deleted the sort-plugin-insert-performance branch Sep 29, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment