Do not use pushstate routing on file:// protocol URLs #1965

Merged
merged 1 commit into from Oct 2, 2015

Conversation

Projects
None yet
1 participant
@daffl
Contributor

daffl commented Oct 1, 2015

Pushstate routing on file:// URLs doesn't work so we shouldn't load it in that case. This is important for mobile and desktop apps that normally load from the file system. Originally tracked at donejs/donejs#92

@daffl daffl added this to the 2.3.0 milestone Oct 1, 2015

@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl Oct 1, 2015

Contributor

I did verify manually but could not add a test since Browsers don't support XHR requests on the file:// protocol.

Contributor

daffl commented Oct 1, 2015

I did verify manually but could not add a test since Browsers don't support XHR requests on the file:// protocol.

daffl added a commit that referenced this pull request Oct 2, 2015

Merge pull request #1965 from bitovi/no-pushstate-on-file
Do not use pushstate routing on file:// protocol URLs

@daffl daffl merged commit c8f9b60 into minor Oct 2, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@daffl daffl deleted the no-pushstate-on-file branch Oct 2, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment