Fix uppercase html parsing #2296

Merged
merged 2 commits into from Mar 1, 2016

Conversation

Projects
None yet
2 participants
@ccummings
Contributor

ccummings commented Mar 1, 2016

If a template uses uppercase HTML tags, can's parser fails to close nested tags properly.

JSBin: http://jsbin.com/zizotavesu/edit?html,css,js,output
This will work if the first </DIV> is changed to </div>.

The parsing for end tags does not use toLowerCase on the tagName, whereas the parsing for start tags does which causes a mismatch in opening/closing tags.

In the JSBin example, the first </DIV> doesn't match the open <div> on the stack and is left open resulting in the second div nesting inside of it.

@daffl daffl added the bug label Mar 1, 2016

@daffl daffl added this to the 2.3.18 milestone Mar 1, 2016

daffl added a commit that referenced this pull request Mar 1, 2016

@daffl daffl merged commit e02b913 into master Mar 1, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@daffl daffl deleted the fix-uppercase-html-parsing branch Mar 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment