-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #1541 can.Component should show a warning if tag name is missing a hyphen #2322
Conversation
@daffl can you see why the build failed? I tried to correct the test but it dosent work in my computer the |
@justinbmeyer Can you tell me please why the build dosent work? |
https://travis-ci.org/canjs/canjs/jobs/115994897#L1717 That's the test that is breaking. Sent from my iPhone
|
@justinbmeyer @daffl this can be merged |
@justinbmeyer can we merge that, or should that PR in https://github.com/canjs/can-view-callbacks ? |
Better in can-stache Sent from my iPhone
|
Ok I will make it in can-stache |
@cherifGsoul thanks... i will merge then... |
i think this is a good update for legacy canjs 2.3 |
fix #1541