Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1541 can.Component should show a warning if tag name is missing a hyphen #2322

Merged
merged 5 commits into from
Aug 10, 2016

Conversation

cherifGsoul
Copy link
Member

fix #1541

@cherifGsoul
Copy link
Member Author

@daffl can you see why the build failed? I tried to correct the test but it dosent work in my computer the npm test pass like a charm

@cherifGsoul
Copy link
Member Author

@justinbmeyer Can you tell me please why the build dosent work?

@justinbmeyer
Copy link
Contributor

https://travis-ci.org/canjs/canjs/jobs/115994897#L1717

That's the test that is breaking.

Sent from my iPhone

On Mar 17, 2016, at 2:49 PM, Mohamed Cherif Bouchelaghem notifications@github.com wrote:

@justinbmeyer Can you tell me please why the build dosent work?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

@cherifGsoul
Copy link
Member Author

@justinbmeyer @daffl this can be merged

@pYr0x
Copy link

pYr0x commented May 11, 2016

@justinbmeyer can we merge that, or should that PR in https://github.com/canjs/can-view-callbacks ?

@justinbmeyer
Copy link
Contributor

Better in can-stache

Sent from my iPhone

On May 11, 2016, at 12:37 AM, Julian notifications@github.com wrote:

@justinbmeyer can we merge that, or should that PR in https://github.com/canjs/can-stache ?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

@cherifGsoul
Copy link
Member Author

Ok I will make it in can-stache

@pYr0x
Copy link

pYr0x commented May 12, 2016

@cherifGsoul thanks... i will merge then...

@pYr0x pYr0x added this to the 2.3.25 milestone Jul 12, 2016
@pYr0x
Copy link

pYr0x commented Jul 12, 2016

i think this is a good update for legacy canjs 2.3

@daffl daffl merged commit cb675d2 into master Aug 10, 2016
@daffl daffl deleted the fix-1541-warning-if-tag-missing-hyphen branch August 10, 2016 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can.Component should show a warning if tag name is missing a hyphen
4 participants