fix #1541 can.Component should show a warning if tag name is missing a hyphen #2322

Merged
merged 5 commits into from Aug 10, 2016

Conversation

Projects
None yet
5 participants
@cherifGsoul
Member

cherifGsoul commented Mar 13, 2016

fix #1541

yiisite added some commits Mar 13, 2016

@cherifGsoul

This comment has been minimized.

Show comment
Hide comment
@cherifGsoul

cherifGsoul Mar 14, 2016

Member

@daffl can you see why the build failed? I tried to correct the test but it dosent work in my computer the npm test pass like a charm

Member

cherifGsoul commented Mar 14, 2016

@daffl can you see why the build failed? I tried to correct the test but it dosent work in my computer the npm test pass like a charm

@cherifGsoul

This comment has been minimized.

Show comment
Hide comment
@cherifGsoul

cherifGsoul Mar 17, 2016

Member

@justinbmeyer Can you tell me please why the build dosent work?

Member

cherifGsoul commented Mar 17, 2016

@justinbmeyer Can you tell me please why the build dosent work?

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Mar 17, 2016

Contributor

https://travis-ci.org/canjs/canjs/jobs/115994897#L1717

That's the test that is breaking.

Sent from my iPhone

On Mar 17, 2016, at 2:49 PM, Mohamed Cherif Bouchelaghem notifications@github.com wrote:

@justinbmeyer Can you tell me please why the build dosent work?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

Contributor

justinbmeyer commented Mar 17, 2016

https://travis-ci.org/canjs/canjs/jobs/115994897#L1717

That's the test that is breaking.

Sent from my iPhone

On Mar 17, 2016, at 2:49 PM, Mohamed Cherif Bouchelaghem notifications@github.com wrote:

@justinbmeyer Can you tell me please why the build dosent work?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

@cherifGsoul

This comment has been minimized.

Show comment
Hide comment
@cherifGsoul

cherifGsoul Apr 17, 2016

Member

@justinbmeyer @daffl this can be merged

Member

cherifGsoul commented Apr 17, 2016

@justinbmeyer @daffl this can be merged

@pYr0x

This comment has been minimized.

Show comment
Hide comment

pYr0x commented May 11, 2016

@justinbmeyer can we merge that, or should that PR in https://github.com/canjs/can-view-callbacks ?

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer May 11, 2016

Contributor

Better in can-stache

Sent from my iPhone

On May 11, 2016, at 12:37 AM, Julian notifications@github.com wrote:

@justinbmeyer can we merge that, or should that PR in https://github.com/canjs/can-stache ?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

Contributor

justinbmeyer commented May 11, 2016

Better in can-stache

Sent from my iPhone

On May 11, 2016, at 12:37 AM, Julian notifications@github.com wrote:

@justinbmeyer can we merge that, or should that PR in https://github.com/canjs/can-stache ?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

@cherifGsoul

This comment has been minimized.

Show comment
Hide comment
@cherifGsoul

cherifGsoul May 12, 2016

Member

Ok I will make it in can-stache

Member

cherifGsoul commented May 12, 2016

Ok I will make it in can-stache

@pYr0x

This comment has been minimized.

Show comment
Hide comment
@pYr0x

pYr0x May 12, 2016

@cherifGsoul thanks... i will merge then...

pYr0x commented May 12, 2016

@cherifGsoul thanks... i will merge then...

@pYr0x pYr0x added this to the 2.3.25 milestone Jul 12, 2016

@pYr0x

This comment has been minimized.

Show comment
Hide comment
@pYr0x

pYr0x Jul 12, 2016

i think this is a good update for legacy canjs 2.3

pYr0x commented Jul 12, 2016

i think this is a good update for legacy canjs 2.3

@daffl daffl merged commit cb675d2 into master Aug 10, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@daffl daffl deleted the fix-1541-warning-if-tag-missing-hyphen branch Aug 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment