Set readOnly property based on val #2436

Merged
merged 1 commit into from Aug 10, 2016

Conversation

Projects
None yet
3 participants
@akagomez
Contributor

akagomez commented Jul 12, 2016

Closes #2431.

@pYr0x

This comment has been minimized.

Show comment
Hide comment
@pYr0x

pYr0x Jul 12, 2016

thx @akagomez , but pls make also a PR against canjs/can-util (https://github.com/canjs/can-util/blob/0ff04106cfd5170727e6bc2f6c0041443e9f481d/dom/attr/attr.js)

and pls dont forget this issue you fixed in can-list-sort to implement into canjs/can-list-sorthttps://github.com/canjs/can-list-sort/issues/3

pYr0x commented Jul 12, 2016

thx @akagomez , but pls make also a PR against canjs/can-util (https://github.com/canjs/can-util/blob/0ff04106cfd5170727e6bc2f6c0041443e9f481d/dom/attr/attr.js)

and pls dont forget this issue you fixed in can-list-sort to implement into canjs/can-list-sorthttps://github.com/canjs/can-list-sort/issues/3

@pYr0x pYr0x self-assigned this Jul 30, 2016

@justinbmeyer justinbmeyer referenced this pull request in canjs/can-util Aug 10, 2016

Closed

Make readOnly fix from 2.3 #36

@daffl daffl added this to the 2.3.25 milestone Aug 10, 2016

@daffl daffl merged commit 45c9ec2 into master Aug 10, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@daffl daffl deleted the 2431-readonly-always-true branch Aug 10, 2016

@daffl daffl removed the in progress label Aug 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment