Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set readOnly property based on val #2436

Merged
merged 1 commit into from
Aug 10, 2016
Merged

Set readOnly property based on val #2436

merged 1 commit into from
Aug 10, 2016

Conversation

akagomez
Copy link
Contributor

Closes #2431.

@pYr0x
Copy link

pYr0x commented Jul 12, 2016

thx @akagomez , but pls make also a PR against canjs/can-util (https://github.com/canjs/can-util/blob/0ff04106cfd5170727e6bc2f6c0041443e9f481d/dom/attr/attr.js)

and pls dont forget this issue you fixed in can-list-sort to implement into canjs/can-list-sorthttps://github.com/canjs/can-list-sort/issues/3

@pYr0x pYr0x self-assigned this Jul 30, 2016
@justinbmeyer justinbmeyer mentioned this pull request Aug 10, 2016
Closed
@daffl daffl added this to the 2.3.25 milestone Aug 10, 2016
@daffl daffl merged commit 45c9ec2 into master Aug 10, 2016
@daffl daffl deleted the 2431-readonly-always-true branch August 10, 2016 18:31
@daffl daffl removed the in progress label Aug 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pYr0x pYr0x

Labels
None yet
Projects
None yet
Milestone
2.3.25
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@akagomez @pYr0x @daffl