can.Observe.Clone #435
can.Observe.Clone #435
Conversation
….save, Model.serialize. no tests yet
…nce it should be optional
|
@airhadoken Are you still interested in seeing this land? I've got some time to look at new 2.1 features. |
| @param deep true to make Clones of all sub-observables. | ||
| */ | ||
| Observe.prototype.clone = function(deep) { | ||
| return new this.constructor.Clone({original : this, deep : !!deep}); |
There was a problem hiding this comment.
It's likely possible to only define the Clone "class" on demand instead of every time a can.Observe "class" is defined.
Could this check if this.constructor.Clone exists and create it.
There was a problem hiding this comment.
It is possible, but it will generate a TypeError if someone attempts to do an instanceof check against the nonexistent Clone class if the check happens before the first cloning creates the class.
|
I still think there's value in it, especially since reciprocity/ggrc-core still has that use case for it. I was interested in hearing whether anyone else would find it to be of value, though #311 shows that at very least the deep copy would be useful. If we can come to a consensus on the line items @justinbmeyer raised, I'll put priority on fixing/tidying it up for release. |
Cloning an Observe instance, by calling clone() on it, copies its properties (optionally deep-cloning nested Observes) to a new object that's an instance of the class's Clone child class. The original Observe's prototype is available in the clone object's prototype chain, in addition to the merge() function, which pushes any changes back to the original object and effectively destroys the clone copy.
Additionally, saving a Clone of a can.Model functions much like a merge() with a round-trip to the AJAX endpoint.
Example use:
make a clone of a page model to populate an Edit form. The original display of the model data is unchanged while pushing form data into the clone copy. When the form is saved by calling save() on the clone model, the original model and any of its live-bound views are updated.