Fix `Model.List.prototype.findAll()` in IE8. #506

Merged
merged 2 commits into from Oct 28, 2013

Conversation

Projects
None yet
2 participants
@asavoy
Contributor

asavoy commented Oct 21, 2013

In IE8, Model.List.prototype.findAll() would trigger "Function.prototype.apply: Array or arguments object expected", since it doesn't like apply() with a Model.List instead of a normal list.

We added a test to /can/model/list/qunit.html which has the error, and shows the fix works.

@imjoshdean

This comment has been minimized.

Show comment
Hide comment
@imjoshdean

imjoshdean Oct 28, 2013

Contributor

Yup, I see your error, ran your test with and without your fix, and it seems to be working. Merging.

Contributor

imjoshdean commented Oct 28, 2013

Yup, I see your error, ran your test with and without your fix, and it seems to be working. Merging.

imjoshdean added a commit that referenced this pull request Oct 28, 2013

Merge pull request #506 from asavoy/model-findAll-ie8
Fix `Model.List.prototype.findAll()` in IE8.

@imjoshdean imjoshdean merged commit d02d9f9 into canjs:master Oct 28, 2013

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment