'key' property breaks mustache helpers #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imjoshdean
added a commit
that referenced
this pull request
Nov 13, 2013
"key" and "index" properties passed into can.Mustache templates no longer break template.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any time an object passed via a mustache template to a helper contains a "key" property, the scope is not passed correctly (probably also true if the object has an "index" or "value" property).
Seems to be due to https://github.com/bitovi/canjs/blob/master/view/mustache/mustache.js#L71.
@imjoshdean looks like its because of the new directives you added to mustache? Can you please take a look?
This test passes in v2.0.0 but fails in v2.0.1