Inside the eventHandler this.scope is not set (as it's called on the scope itself) #550

Merged
merged 1 commit into from Nov 20, 2013

Conversation

Projects
None yet
2 participants
@ghost

ghost commented Nov 15, 2013

Interestingly enough, this does not make any difference at all to any of the tests - I was trying to solve another problem with my code and just stumbled over this. Maybe someone can shed a bit light onto this line and what it does. @justinbmeyer maybe?

simpleTechs
Inside the eventHandler this.scope is not set (as it's called on the …
…scope itself)

Interestingly enough, this does not make any difference at all to any of the tests - I was trying to solve another problem with my code and just stumbled over this. Maybe someone can shed a bit light onto this line and what it does. @justinbmeyer maybe?
@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Nov 20, 2013

Contributor

Actually, it's because this.on automatically calls the function back with this as the control so that var self is unnecessary. Anyway you can submit a pull that just removes the var self?

Contributor

justinbmeyer commented Nov 20, 2013

Actually, it's because this.on automatically calls the function back with this as the control so that var self is unnecessary. Anyway you can submit a pull that just removes the var self?

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Nov 20, 2013

Contributor

Actually .. maybe not. Great catch!

Contributor

justinbmeyer commented Nov 20, 2013

Actually .. maybe not. Great catch!

justinbmeyer added a commit that referenced this pull request Nov 20, 2013

@justinbmeyer justinbmeyer merged commit ce8dc35 into canjs:master Nov 20, 2013

1 check passed

default The Travis CI build passed
Details

@simpleTechs simpleTechs deleted the simpleTechs:patch-2 branch Dec 9, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment