Inside the eventHandler this.scope is not set (as it's called on the scope itself) #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…scope itself) Interestingly enough, this does not make any difference at all to any of the tests - I was trying to solve another problem with my code and just stumbled over this. Maybe someone can shed a bit light onto this line and what it does. @justinbmeyer maybe?
|
Actually, it's because this.on automatically calls the function back with |
|
Actually .. maybe not. Great catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interestingly enough, this does not make any difference at all to any of the tests - I was trying to solve another problem with my code and just stumbled over this. Maybe someone can shed a bit light onto this line and what it does. @justinbmeyer maybe?