can-value shows "undefined" if bound to undefined value #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s not yet inside the map.
…lue bound is undefined.
|
Awesome! Thanks for the test! |
daffl
added a commit
that referenced
this pull request
Dec 3, 2013
can-value shows "undefined" if bound to undefined value
|
Sweet! Ran into that yesterday myself, thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the super-cool
can-value-attribute in mustache, I recently ran into the situation of a database-model, that would actually only contain fields that contained data, i.e. that not set the rest of the fields to some default or undefined.While (probably) saving some conneciton-overhead (think json with 500 empty + 2 non-empty fields vs. just 2 fields), this happens to make
can-valueshowundefinedin the view - something you would never want to show to the user :-)This pull-request will fix only the view-binding, i.e. the value still is
undefined(which is totally intended!).