New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore will not remove properties that were added since the last backup #607

Merged
merged 1 commit into from Dec 20, 2013

Conversation

Projects
None yet
2 participants
@daffl
Contributor

daffl commented Dec 20, 2013

restore will not remove properties that were added since the last backup

Per http://canjs.com/docs/can.Map.backup.prototype.restore.html

This is never the behavior I would want from backup/restore. In restore, this._attrs(props); could be called with 'true' as the second argument to remove new properties, and that could be an optional attribute on restore.

@daffl daffl reopened this Dec 20, 2013

daffl added a commit that referenced this pull request Dec 20, 2013

Merge pull request #607 from bitovi/backup-can-remove-props
restore will not remove properties that were added since the last backup

@daffl daffl merged commit 8e95d59 into master Dec 20, 2013

1 check passed

default The Travis CI build passed
Details

@daffl daffl deleted the backup-can-remove-props branch Dec 20, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment