Fixes nested components and `<content>` tags. #619

Merged
merged 14 commits into from Dec 19, 2013

Conversation

Projects
None yet
2 participants
@justinbmeyer
Contributor

justinbmeyer commented Dec 19, 2013

As identified by #549, this fixes a bug with nested content tags by:

Making sure helpers are passed the same way as scope. Essentially parent helpers were not available. 586520c#diff-9ede961af024a842ba5e956318112b39R238 This was a bug waiting to be found.

Changing scanner to look all the way to content: 586520c#diff-08e58b9c9e7b5aea7a452a3e45ca998fR190. This would previously stop once it found a tags object, I needed it to keep going if it didn't find the actual matching tag.

Then I temporarily remove the tag.content callback while rendering the content. 586520c#diff-9ede961af024a842ba5e956318112b39R222 This is the core problem, that if you were rendering a <content>s content that had another <content> within it, it would keep rendering the parent content. By deleting it, and changing scanner, scanner will go to the previous parent's content tag callback.

daffl added a commit that referenced this pull request Dec 19, 2013

Merge pull request #619 from bitovi/whitecolor-compontent-content-ove…
…rflow-bug

Fixes nested components and `<content>` tags.

@daffl daffl merged commit adca7e1 into master Dec 19, 2013

1 check passed

default The Travis CI build passed
Details

@daffl daffl deleted the whitecolor-compontent-content-overflow-bug branch Dec 19, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment