New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing variable format so it doesn't break Steal build #654

Merged
merged 2 commits into from Jan 8, 2014

Conversation

Projects
None yet
2 participants
@thecountofzero
Contributor

thecountofzero commented Jan 8, 2014

I don't think env.js likes the format of the variables and it causes the build to fail.

@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl Jan 8, 2014

Contributor

What's the error message? And can we call it first and second instead of FooBar?

Contributor

daffl commented Jan 8, 2014

What's the error message? And can we call it first and second instead of FooBar?

@thecountofzero

This comment has been minimized.

Show comment
Hide comment
@thecountofzero

thecountofzero Jan 8, 2014

Contributor

Here is the error message:

Building myapp/production.js
 last = index + $0.l
ength;
 }
 });

Parsing problem
steal/parse/tokens.js Bad number with 0.l.
 last = index + $0.length;
 }
 });
 names.push(attr.slice(la
Contributor

thecountofzero commented Jan 8, 2014

Here is the error message:

Building myapp/production.js
 last = index + $0.l
ength;
 }
 });

Parsing problem
steal/parse/tokens.js Bad number with 0.l.
 last = index + $0.length;
 }
 });
 names.push(attr.slice(la
@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl Jan 8, 2014

Contributor

Fair enough. Thanks for updating. Merging into 2.0.5

Contributor

daffl commented Jan 8, 2014

Fair enough. Thanks for updating. Merging into 2.0.5

daffl added a commit that referenced this pull request Jan 8, 2014

Merge pull request #654 from thecountofzero/master
Fixing variable format so it doesn't break Steal build

@daffl daffl merged commit 55d140b into canjs:master Jan 8, 2014

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment