Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for incorrect ignore attributes pattern #694

Closed
wants to merge 1 commit into from
Closed

Fix for incorrect ignore attributes pattern #694

wants to merge 1 commit into from

Conversation

wclr
Copy link
Contributor

@wclr wclr commented Jan 23, 2014

var ignoreAttributesRegExp = /dataViewId|class|id/i

matches all words that contain id/class letters, not the whole words

/^(dataViewId|class|id)$/i 

fixes things.

@ghost ghost assigned zkat Jan 23, 2014
@zkat zkat mentioned this pull request Jan 23, 2014
@zkat
Copy link
Contributor

zkat commented Jan 23, 2014

This change is included in #701. I moved it to that pull request because I wrote a test to verify the change. Thanks for the patch!

@zkat zkat closed this Jan 23, 2014
@wclr
Copy link
Contributor Author

wclr commented Jan 23, 2014

One more thing "i" modifier is exessive there. And look at this issue #695 I had to add more in pattern to overcome it.

@wclr wclr unassigned zkat Oct 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants