Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added can parameter #980

Merged
merged 4 commits into from
May 16, 2014
Merged

added can parameter #980

merged 4 commits into from
May 16, 2014

Conversation

gsmeets
Copy link
Contributor

@gsmeets gsmeets commented May 9, 2014

can.view.parser is set at the end of the file. The dependency can is
not imported, this causes issues during AMD optimization, because the
reference can at that point doesn't exist through window.can, as it
does in the browser.

`can.view.parser` is set at the end of the file. The dependency `can` is
not imported, this causes issues during AMD optimization, because the
reference can at that point doesn't exist through `window.can`, as it
does in the browser.
@gsmeets
Copy link
Contributor Author

gsmeets commented May 9, 2014

Hmm, seems like I'm running into some more of these issues. I'll add those to this pull request once I've fixed them..

@ccummings ccummings added the Bug label May 9, 2014
@ccummings ccummings added this to the 2.1.1 milestone May 9, 2014
Several properties are set on `can` in the file. The dependency `can` is
not imported, this causes issues during AMD optimization, because the
reference `can` at that point doesn't exist through `window.can`, as it
does in the browser.
@gsmeets
Copy link
Contributor Author

gsmeets commented May 12, 2014

I've added another can import for view/stache/stache.js. Now I got stache precompiled templates running on node. I've imported can/util/library.js for lack of a better candidate. Doesn't seem to matter that much, as long as there's some prototype to extend that will be picked up later by other components.

@justinbmeyer
Copy link
Contributor

It should not be can. That forces a dependency on everything in core. It should be 'can/util'.

Sent from my iPhone

On May 12, 2014, at 5:10 PM, Guido Smeets notifications@github.com wrote:

I've added another can import for view/stache/stache.js. Now I got stache precompiled templates running on node. I've imported can/util/library.js for lack of a better candidate. Doesn't seem to matter that much, as long as there's some prototype to extend that will be picked up later by other components.


Reply to this email directly or view it on GitHub.

@gsmeets
Copy link
Contributor Author

gsmeets commented May 13, 2014

To clarify, for can/view/parser I just added a parameter name for the already imported can/view. For can/view/stache/stache I added can/util/library as a reference. Both imports are named can locally.

(p.s. Travis reports failed builds. Is that due to my changes? Seems unlikely to me.)

@justinbmeyer
Copy link
Contributor

can/util/library should be can/util.

@justinbmeyer
Copy link
Contributor

the can/util/library might have broken it.

changed reference from `can/util/library` to `can/util` to fix the
dependency. This does seem to work for both the steal and the amd
versions.
ccummings pushed a commit that referenced this pull request May 16, 2014
@ccummings ccummings merged commit 8d0df68 into canjs:master May 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants