-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added can parameter #980
added can parameter #980
Conversation
`can.view.parser` is set at the end of the file. The dependency `can` is not imported, this causes issues during AMD optimization, because the reference can at that point doesn't exist through `window.can`, as it does in the browser.
Hmm, seems like I'm running into some more of these issues. I'll add those to this pull request once I've fixed them.. |
Several properties are set on `can` in the file. The dependency `can` is not imported, this causes issues during AMD optimization, because the reference `can` at that point doesn't exist through `window.can`, as it does in the browser.
I've added another can import for view/stache/stache.js. Now I got stache precompiled templates running on node. I've imported can/util/library.js for lack of a better candidate. Doesn't seem to matter that much, as long as there's some prototype to extend that will be picked up later by other components. |
It should not be can. That forces a dependency on everything in core. It should be 'can/util'. Sent from my iPhone
|
To clarify, for (p.s. Travis reports failed builds. Is that due to my changes? Seems unlikely to me.) |
|
the can/util/library might have broken it. |
changed reference from `can/util/library` to `can/util` to fix the dependency. This does seem to work for both the steal and the amd versions.
can.view.parser
is set at the end of the file. The dependencycan
isnot imported, this causes issues during AMD optimization, because the
reference
can
at that point doesn't exist throughwindow.can
, as itdoes in the browser.