Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the lowest Debian version to Bookworm in CI #195

Merged
merged 2 commits into from Jul 10, 2023

Conversation

schopin-pro
Copy link
Contributor

@schopin-pro schopin-pro commented Jul 6, 2023

The latest Debian stable is Bookworm, not Bullseye anymore.

@schopin-pro schopin-pro requested a review from bdrung July 6, 2023 10:48
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #195 (e53b2c0) into main (1d374b8) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #195      +/-   ##
==========================================
- Coverage   82.66%   82.66%   -0.01%     
==========================================
  Files          91       91              
  Lines       18544    18525      -19     
==========================================
- Hits        15329    15313      -16     
+ Misses       3215     3212       -3     
Impacted Files Coverage Δ
apport/packaging.py 65.11% <100.00%> (-4.05%) ⬇️
apport/packaging_impl/__init__.py 82.35% <100.00%> (+1.10%) ⬆️
apport/packaging_impl/apt_dpkg.py 83.42% <100.00%> (+0.01%) ⬆️
tests/unit/test_packaging_impl.py 100.00% <100.00%> (ø)

@schopin-pro schopin-pro force-pushed the gh-action-bump branch 9 times, most recently from 1df8994 to a26df1e Compare July 7, 2023 15:30
@schopin-pro schopin-pro changed the title Bump the CI platforms to most recent Debian and Ubuntu Bump the CI platforms to most recent and Ubuntu Jul 10, 2023
@schopin-pro
Copy link
Contributor Author

I greatly reduced the scope of this PR as it turns out we can't have runners that run interim Ubuntu releases, only LTS, which means our installed tests can't be run on Lunar. That means more work on #193 to fallback on old style when appropriate.

@schopin-pro schopin-pro force-pushed the gh-action-bump branch 3 times, most recently from f032dd5 to 519ee7b Compare July 10, 2023 09:39
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
apport/packaging.py Outdated Show resolved Hide resolved
Python 3.10 is the default in Jammy, while Debian Bookworm has 3.11.
Since we dropped CI for older releases, we need to remove compatibility
code that won't be exercised in the tests.
@schopin-pro schopin-pro changed the title Bump the CI platforms to most recent and Ubuntu Bump the lowest Debian version to Bookworm in CI Jul 10, 2023
Copy link
Collaborator

@bdrung bdrung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I will merge them once the pipelines succeeded.

@bdrung bdrung merged commit 0ba290f into canonical:main Jul 10, 2023
24 checks passed
@schopin-pro schopin-pro deleted the gh-action-bump branch February 13, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants