test/launchpad: Some refactorings #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #235 +/- ##
==========================================
+ Coverage 83.69% 83.72% +0.02%
==========================================
Files 93 93
Lines 18757 18751 -6
==========================================
Hits 15699 15699
+ Misses 3058 3052 -6
|
schopin-pro
approved these changes
Oct 31, 2023
Shorten the code by importing `Report` instead of using `apport.report.Report`. Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Move duplicate code into the helper function `_create_bug_from_report`. Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Let `_file_bug` return the web link to avoid needing to construct it on our own afterwards. Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apport.report_create_bug_from_report()_file_bug_file_bug_generate_sigsegv_report_generate_sigsegv_report()Successfully tested Launchpad tests locally:
So the failing codecov/patch can be ignored.