Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/launchpad: Some refactorings #235

Merged
merged 6 commits into from
Oct 31, 2023
Merged

test/launchpad: Some refactorings #235

merged 6 commits into from
Oct 31, 2023

Commits on Oct 31, 2023

  1. test/launchpad: Import Report from apport.report 

    Shorten the code by importing `Report` instead of using
`apport.report.Report`.

Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
    @bdrung
    bdrung committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    b29bfc4 View commit details
    Browse the repository at this point in the history

  2. test/launchpad: Introduce _create_bug_from_report() 

    Move duplicate code into the helper function `_create_bug_from_report`.

Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
    @bdrung
    bdrung committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    4b79b9c View commit details
    Browse the repository at this point in the history

  3. test/launchpad: set default description in _file_bug 

    Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
    @bdrung
    bdrung committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    198bec4 View commit details
    Browse the repository at this point in the history

  4. test/launchpad: Also return web_link in _file_bug 

    Let `_file_bug` return the web link to avoid needing to construct it on
our own afterwards.

Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
    @bdrung
    bdrung committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    4030862 View commit details
    Browse the repository at this point in the history

  5. test/launchpad: pass signal as int to _generate_sigsegv_report 

    Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
    @bdrung
    bdrung committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    0a92011 View commit details
    Browse the repository at this point in the history

  6. test/launchpad: Move more parts into _generate_sigsegv_report() 

    Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
    @bdrung
    bdrung committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    c7e96c4 View commit details
    Browse the repository at this point in the history