Add type hints to UserInterface class #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI is green except that upload-to-codecov is failing. |
`MainUserInterface.ui_start_info_collection_progress` is expected to be called before `MainUserInterface.ui_stop_info_collection_progress`. After the call of `MainUserInterface.ui_start_info_collection_progress` either `MainUserInterface.dialog` or `MainUserInterface.progress` is set. Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
`MainUserInterface.ui_start_upload_progress` is expected to be called before `MainUserInterface.ui_stop_upload_progress`. The former will set MainUserInterface.progress`. Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Add type hints to all occurrences of the `UserInterface` class. mypy on jammy has false positives: ``` kde/apport-kde:441: error: Argument 1 to "information" of "QMessageBox" has incompatible type "None"; expected "QWidget" kde/apport-kde:444: error: Argument 1 to "information" of "QMessageBox" has incompatible type "None"; expected "QWidget" kde/apport-kde:535: error: Argument 1 to "question" of "QMessageBox" has incompatible type "None"; expected "QWidget" ``` Do not install `python3-pyqt5` on jammy to avoid those false positives. Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add type hints to all occurrences of the
UserInterfaceclass.mypy on jammy has false positives:
Do not install
python3-pyqt5on jammy to avoid those false positives.