apport: create /var/crash with setgid permission #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case `/var/crash` exists, let `apport --start` not modify the permission of the directory. Otherwise the permission might be changed to an unwanted mode (see discussion in the linked bug). Bug: https://launchpad.net/bugs/2066995
Create `/var/crash` with mode 3777 instead of 1777 to have the `setgid` permission set. The `setgid` permission causes crash files created in `/var/crash` to inherit its group ownership. Bug: https://launchpad.net/bugs/2066995 Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #349 +/- ##
==========================================
+ Coverage 82.07% 82.28% +0.20%
==========================================
Files 96 96
Lines 19819 19820 +1
Branches 3211 3215 +4
==========================================
+ Hits 16266 16308 +42
+ Misses 3027 2998 -29
+ Partials 526 514 -12 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case
/var/crashexists, letapport --startnot modify the permission of the directory. Otherwise the permission might be changed to an unwanted mode (see discussion in the linked bug).Create
/var/crashwith mode 3777 instead of 1777 to have thesetgidpermission set. Thesetgidpermission causes crash files created in/var/crashto inherit its group ownership.Bug: https://launchpad.net/bugs/2066995