New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'charm-strict-dependencies' requires at least one requirements file. in field 'parts.charm.charm-strict-dependencies' #1389
Comments
Issue also on charmcraft latest/candidate (rev 1790 2.5.0.post1+gitf5558b8) |
Thanks for the report! This bug is actually in the |
The only way I've been able to reproduce this is by deleting Since this behaviour already infers a requirements.txt file (if it exists), I'm going to leave it that way. |
oh sorry, I think that might be because of this
on mysql-router-k8s, we're using a wrapper around charmcraft to generate requirements.txt from poetry.lock you can run |
Fixes canonical/charmcraft#1389 Signed-off-by: Alex Lowe <alex.lowe@canonical.com>
Fixes canonical/charmcraft#1389 Signed-off-by: Alex Lowe <alex.lowe@canonical.com>
Ah, looking at We might be able to make the |
Tried reproducing this & wasn't able to (even with same snap revision) It appears that charmcraft clean does not require requirements.txt |
Encountering this issue again on 2.5.4 with https://github.com/canonical/mysql-router-k8s-operator/ branch |
@lengau This is affecting https://github.com/canonical/charming-actions e.g. failing release CI https://github.com/canonical/mysql-router-k8s-operator/actions/runs/7447379642/job/20259574786 |
charmcraft bug causes check-lib check to fail canonical/charmcraft#1389 (comment)
charmcraft bug causes check-lib check to fail canonical/charmcraft#1389 (comment)
charmcraft bug causes check-lib check to fail canonical/charmcraft#1389 (comment)
charmcraft bug causes check-lib check to fail canonical/charmcraft#1389 (comment)
charmcraft bug causes check-lib check to fail canonical/charmcraft#1389 (comment)
charmcraft bug causes check-lib check to fail canonical/charmcraft#1389 (comment)
charmcraft bug causes check-lib check to fail canonical/charmcraft#1389 (comment)
charmcraft bug causes check-lib check to fail canonical/charmcraft#1389 (comment)
Also causing issues when uploading charms: https://github.com/canonical/mysql-router-k8s-operator/actions/runs/7449117799/job/20267404751 Workaround: delete charmcraft.yaml (e.g. https://github.com/canonical/data-platform-workflows/pull/119/files) |
I'm surprised this affects commands like |
Includes workaround for canonical/charmcraft#1389 to fix release CI
Includes workaround for canonical/charmcraft#1389 to fix release CI
Includes workaround for canonical/charmcraft#1389 to fix release CI
Includes workaround for canonical/charmcraft#1389 to fix release CI
Dear @lengau Can you please revise your decision to close this without fixing. It affects Data SQL charms... as even Thank you in advance! |
Thank you for reporting us your feedback! The internal ticket has been created: https://warthogs.atlassian.net/browse/CRAFT-2509.
|
charmcraft bug causes check-lib check to fail canonical/charmcraft#1389 (comment)
OK @taurus-forever , @carlcsaposs-canonical , I'm convinced :-) The fix probably won't make it into 3.0.0, but I'm going to consider options for how to better resolve this in Charmcraft. |
Hello! Just checking in this issue, I faced the same issue during my onboarding tasks. |
Bug Description
I'm guessing
charm-strict-dependencies
defaults to requirements.txt during charmcraft pack? Looks like the same default doesn't apply tocharmcraft clean
To Reproduce
charmcraft installed from edge (rev 1824 2.5.0.post16+git23bf390)
Environment
Ubuntu 22.04
charmcraft.yaml
Relevant log output
charmcraft-20231124-090230.749172.log
charmcraft-20231124-084822.286563.log
The text was updated successfully, but these errors were encountered: